Skip to content

Add LibrarySort Implementation#7481

Open
Rosander0 wants to merge 3 commits into
TheAlgorithms:masterfrom
Rosander0:add-library-sort
Open

Add LibrarySort Implementation#7481
Rosander0 wants to merge 3 commits into
TheAlgorithms:masterfrom
Rosander0:add-library-sort

Conversation

@Rosander0

@Rosander0 Rosander0 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new algorithms include a corresponding test class that validates their functionality.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter

codecov-commenter commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.52632% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.30%. Comparing base (80fc2bd) to head (b93a13a).

Files with missing lines Patch % Lines
...main/java/com/thealgorithms/sorts/LibrarySort.java 90.52% 5 Missing and 4 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #7481      +/-   ##
============================================
+ Coverage     80.24%   80.30%   +0.05%     
- Complexity     7357     7390      +33     
============================================
  Files           810      811       +1     
  Lines         23787    23882      +95     
  Branches       4678     4701      +23     
============================================
+ Hits          19089    19178      +89     
- Misses         3941     3944       +3     
- Partials        757      760       +3

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DenizAltunkapan DenizAltunkapan requested a review from Copilot June 18, 2026 07:20
Copilot AI reviewed Jun 18, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new LibrarySort implementation under com.thealgorithms.sorts, along with a dedicated JUnit test class to validate basic behavior.

Changes:

  • Introduces LibrarySort sorting implementation and API (LibrarySort.sort(int[])).
  • Adds LibrarySortTest with basic correctness and input-validation tests (including null input).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/main/java/com/thealgorithms/sorts/LibrarySort.java Adds the new sorting implementation and its Javadoc/API.
src/test/java/com/thealgorithms/sorts/LibrarySortTest.java Adds unit tests covering common input shapes and null handling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main/java/com/thealgorithms/sorts/LibrarySort.java
Comment thread src/main/java/com/thealgorithms/sorts/LibrarySort.java
Comment thread src/main/java/com/thealgorithms/sorts/LibrarySort.java Outdated
@Rosander0

Rosander0 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Hi, just wanted to follow up on this PR — all the requested changes have been addressed and comments resolved. Could you take another look when you get a chance? Happy to make any further adjustments if needed. Thanks!

@Rosander0

Rosander0 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Hi, pinging once more on this — all the flagged errors have been addressed and comments resolved. Let me know if there's anything else you'd like changed before merging. Thanks!

DenizAltunkapan
DenizAltunkapan requested changes Jul 2, 2026
View reviewed changes

@DenizAltunkapan DenizAltunkapan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! The code is clean and well tested. A few changes are needed first:

  1. This is not really Library Sort. The Javadoc admits there are no gaps, so it is basically insertion sort with binary search (O(n^2)). Please implement the actual gapped version, or the algorithm does not add something new to the repo.
  2. Integer[] boxing. Using Integer[] with null markers to find gaps is slow and memory-heavy. If you keep the gapped design, please track filled positions without boxing.
  3. Move the author tag. // author: ... on line 2 of the test file should not be there; author info belongs in the class Javadoc.

If you switch to a true gapped implementation, the current tests are a good base to keep.

@Rosander0 Rosander0 force-pushed the add-library-sort branch 2 times, most recently from 372ca36 to 0af0297 Compare July 5, 2026 05:47
@Rosander0 Rosander0 requested a review from DenizAltunkapan July 5, 2026 06:20
@Rosander0

Rosander0 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the detailed feedback! I've pushed an update that addresses all three points:

  1. Actual gapped implementation — the array is now allocated at 2 * n capacity with real empty slots distributed via a rebalancing step between insertion rounds. Insertions land directly in gaps when possible, or shift toward the nearest one, rather than doing a plain insertion-sort shift every time.
  2. No boxing — switched to a primitive int[] data paired with a boolean[] occupied to track filled positions, so there's no Integer[]/null overhead.
  3. Author tag — moved out of the test file and into the class Javadoc where it belongs.

Let me know if anything else stands out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner
@alxkm alxkm Awaiting requested review from alxkm alxkm is a code owner
@DenizAltunkapan DenizAltunkapan Awaiting requested review from DenizAltunkapan DenizAltunkapan is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Rosander0 @codecov-commenter @DenizAltunkapan